[PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20

[Xu, Feifei]

I will remove the DRM_INFO and send v2. Thanks.

-----Original Message-----
From: Quan, Evan <Evan.Quan at amd.com> 
Sent: Monday, December 10, 2018 1:10 PM
To: Xu, Feifei <Feifei.Xu at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Xu, Feifei <Feifei.Xu at amd.com>
Subject: RE: [PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20

Is the DRM_INFO print necessary?
And it will get printed even running on other ASIC.

Regards,
Evan
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of 
> Feifei Xu
> Sent: 2018年12月10日 12:46
> To: amd-gfx at lists.freedesktop.org
> Cc: Xu, Feifei <Feifei.Xu at amd.com>
> Subject: [PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20
> 
> On vega20, the job of executing the ASIC_INIT table when posting card 
> is moved to psp. Skip the atombios's ASIC_INIT on vega20 when posting card.
> 
> Change-Id: Id1d3c0a0d19296d5ed804de7edf5b09b8d38c0a5
> Signed-off-by: Feifei Xu <Feifei.Xu at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index f2bda76c8e05..310d4eb0536b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2513,8 +2513,9 @@ int amdgpu_device_init(struct amdgpu_device 
> *adev,
>  	/* detect if we are with an SRIOV vbios */
>  	amdgpu_device_detect_sriov_bios(adev);
> 
> +    DRM_INFO("skip posting card using ASIC INIT table in vbios on 
> + vega20\n");
>  	/* Post card if necessary */
> -	if (amdgpu_device_need_post(adev)) {
> +	if ((adev->asic_type != CHIP_VEGA20) &&
> amdgpu_device_need_post(adev))
> +{
>  		if (!adev->bios) {
>  			dev_err(adev->dev, "no vBIOS found\n");
>  			r = -EINVAL;
> --
> 2.17.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx