[PATCH] Revert "drm/amd/display: Set RMX_ASPECT as default"

[Li, Sun peng (Leo)]

Reviewed-by: Leo Li <sunpeng.li at amd.com>

On 2018-12-07 1:10 p.m., Deucher, Alexander wrote:
> Acked-by: Alex Deucher <alexander.deucher at amd.com>
> 
> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of 
> Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>
> *Sent:* Friday, December 7, 2018 12:15:01 PM
> *To:* amd-gfx at lists.freedesktop.org
> *Cc:* Li, Sun peng (Leo); Wentland, Harry; Lakha, Bhawanpreet; 
> Kazlauskas, Nicholas
> *Subject:* [PATCH] Revert "drm/amd/display: Set RMX_ASPECT as default"
> This reverts commit 91b66c47ba3468f7882ea4a84d5e0e0c186b638f.
> 
> Forcing RMX_ASPECT as default uses the preferred/native mode's timings
> for any mode the user selects and scales the image. This provides a
> a consistently nicer result in the case where the selected mode's
> refresh rate matches the native mode's refresh but this isn't always
> the case.
> 
> For example, if the monitor is 1080p at 144Hz and the preferred mode is
> 60Hz then even if the user selects 1080p at 144Hz as their selected mode
> they'll get 1080p at 60Hz.
> 
> Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha at amd.com>
> Cc: Leo Li <sunpeng.li at amd.com>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 23d61570df17..fa2b00ad1713 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3100,10 +3100,8 @@ int 
> amdgpu_dm_connector_atomic_set_property(struct drm_connector *connector,
>                           rmx_type = RMX_FULL;
>                           break;
>                   case DRM_MODE_SCALE_NONE:
> -                       rmx_type = RMX_OFF;
> -                       break;
>                   default:
> -                       rmx_type = RMX_ASPECT;
> +                       rmx_type = RMX_OFF;
>                           break;
>                   }
> 
> @@ -3216,7 +3214,7 @@ void amdgpu_dm_connector_funcs_reset(struct 
> drm_connector *connector)
>           state = kzalloc(sizeof(*state), GFP_KERNEL);
> 
>           if (state) {
> -               state->scaling = RMX_ASPECT;
> +               state->scaling = RMX_OFF;
>                   state->underscan_enable = false;
>                   state->underscan_hborder = 0;
>                   state->underscan_vborder = 0;
> -- 
> 2.17.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx