[PATCH 2/2] drm/amdgpu/virtual_dce: No need to pin the cursor bo

Deng, Emily Emily.Deng at amd.com
Wed Dec 26 02:26:34 UTC 2018


Ping......

Best wishes
Emily Deng



>-----Original Message-----
>From: Deng, Emily <Emily.Deng at amd.com>
>Sent: Tuesday, December 25, 2018 11:53 AM
>To: Deng, Emily <Emily.Deng at amd.com>; amd-gfx at lists.freedesktop.org
>Subject: RE: [PATCH 2/2] drm/amdgpu/virtual_dce: No need to pin the cursor bo
>
>Ping......
>Please help to review. This issue will gate promotion to mainline, as startx will
>have call trace when use virtual display.
>
>>-----Original Message-----
>>From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of
>>Emily Deng
>>Sent: Monday, December 24, 2018 2:09 PM
>>To: amd-gfx at lists.freedesktop.org
>>Cc: Deng, Emily <Emily.Deng at amd.com>
>>Subject: [PATCH 2/2] drm/amdgpu/virtual_dce: No need to pin the cursor
>>bo
>>
>>For virtual display feature, no need to pin cursor bo.
>>
>>Signed-off-by: Emily Deng <Emily.Deng at amd.com>
>>---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>>b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>>index 8a078f4..98df8e4 100644
>>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>>@@ -2798,7 +2798,7 @@ int amdgpu_device_suspend(struct drm_device *dev,
>>bool suspend, bool fbcon)
>> 			struct drm_framebuffer *fb = crtc->primary->fb;
>> 			struct amdgpu_bo *robj;
>>
>>-			if (amdgpu_crtc->cursor_bo) {
>>+			if (amdgpu_crtc->cursor_bo && !adev-
>>>enable_virtual_display) {
>> 				struct amdgpu_bo *aobj =
>>gem_to_amdgpu_bo(amdgpu_crtc->cursor_bo);
>> 				r = amdgpu_bo_reserve(aobj, true);
>> 				if (r == 0) {
>>@@ -2906,7 +2906,7 @@ int amdgpu_device_resume(struct drm_device *dev,
>>bool resume, bool fbcon)
>> 		list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
>> 			struct amdgpu_crtc *amdgpu_crtc =
>>to_amdgpu_crtc(crtc);
>>
>>-			if (amdgpu_crtc->cursor_bo) {
>>+			if (amdgpu_crtc->cursor_bo && !adev-
>>>enable_virtual_display) {
>> 				struct amdgpu_bo *aobj =
>>gem_to_amdgpu_bo(amdgpu_crtc->cursor_bo);
>> 				r = amdgpu_bo_reserve(aobj, true);
>> 				if (r == 0) {
>>--
>>2.7.4
>>
>>_______________________________________________
>>amd-gfx mailing list
>>amd-gfx at lists.freedesktop.org
>>https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list