[PATCH 3/3] drm/amd/powerplay: implement set_mmhub_powergating_by_smu for Raven

Deucher, Alexander Alexander.Deucher at amd.com
Tue Feb 6 20:55:31 UTC 2018


> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Eric Huang
> Sent: Tuesday, February 6, 2018 3:41 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Huang, JinHuiEric <JinHuiEric.Huang at amd.com>
> Subject: [PATCH 3/3] drm/amd/powerplay: implement
> set_mmhub_powergating_by_smu for Raven
> 

Please add a basic patch description.  With that fixed:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>


> Signed-off-by: Eric Huang <JinHuiEric.Huang at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 6 ++++++
>  drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h   | 3 ++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
> index 409a56b..8ddfb78 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
> @@ -1026,6 +1026,11 @@ static int rv_read_sensor(struct pp_hwmgr
> *hwmgr, int idx,
>  	return ret;
>  }
> 
> +static int rv_set_mmhub_powergating_by_smu(struct pp_hwmgr *hwmgr)
> {
> +	return smum_send_msg_to_smc(hwmgr,
> PPSMC_MSG_PowerGateMmHub); }
> +
>  static const struct pp_hwmgr_func rv_hwmgr_funcs = {
>  	.backend_init = rv_hwmgr_backend_init,
>  	.backend_fini = rv_hwmgr_backend_fini, @@ -1059,6 +1064,7 @@
> static const struct pp_hwmgr_func rv_hwmgr_funcs = {
>  	.asic_setup = rv_setup_asic_task,
>  	.power_state_set = rv_set_power_state_tasks,
>  	.dynamic_state_management_disable = rv_disable_dpm_tasks,
> +	.set_mmhub_powergating_by_smu =
> rv_set_mmhub_powergating_by_smu,
>  };
> 
>  int rv_init_function_pointers(struct pp_hwmgr *hwmgr) diff --git
> a/drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h
> b/drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h
> index f15f4df..426bff2 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h
> @@ -80,7 +80,8 @@
>  #define PPSMC_MSG_SetSoftMaxSocclkByFreq        0x32
>  #define PPSMC_MSG_SetSoftMaxFclkByFreq          0x33
>  #define PPSMC_MSG_SetSoftMaxVcn                 0x34
> -#define PPSMC_Message_Count                     0x35
> +#define PPSMC_MSG_PowerGateMmHub                0x35
> +#define PPSMC_Message_Count                     0x36
> 
> 
>  typedef uint16_t PPSMC_Result;
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list