[PATCH v2 xf86-video-amdgpu] Don't bail from drmmode_set_desired_modes immediately

Michel Dänzer michel at daenzer.net
Fri Feb 16 08:29:39 UTC 2018


On 2018-02-15 10:05 PM, Harry Wentland wrote:
> On 2018-02-15 12:49 PM, Michel Dänzer wrote:
>> From: Michel Dänzer <michel.daenzer at amd.com>
>>
>> If we fail to find or set the mode for a CRTC, keep trying for the
>> remaining CRTCs, and only return FALSE if we failed for all CRTCs that
>> should be on.
>>
>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> Thanks. This should help when bandwidth checks in DC fail.

It might in some cases, though I'm afraid it won't make any difference
in the case you're probably thinking of (not enough bandwidth for 3 4K
monitors connected to an APU), in that case two monitors should light up
either way. But if there was e.g. a fourth 1080 monitor connected, that
might light up now, whereas it might not have before.


> Acked-by: Harry Wentland <harry.wentland at amd.com>

Thanks!


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list