[PATCH] drm/amdgpu: use the TTM dummy page instead of allocating one

[Alex Deucher]

On Thu, Feb 22, 2018 at 3:29 AM, Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
> We have a global dummy page in TTM, use that one instead of allocating a
> new one.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h      | 10 +---------
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 29 +++++++++++++----------------
>  drivers/gpu/drm/amd/amdgpu/cik_ih.c      |  2 +-
>  drivers/gpu/drm/amd/amdgpu/cz_ih.c       |  2 +-
>  drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c |  4 ++--
>  drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c    |  4 ++--
>  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c    |  4 ++--
>  drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c    |  4 ++--
>  drivers/gpu/drm/amd/amdgpu/iceland_ih.c  |  2 +-
>  drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c  |  4 ++--
>  drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c   |  2 +-
>  drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c   |  2 +-
>  drivers/gpu/drm/amd/amdgpu/tonga_ih.c    |  2 +-
>  13 files changed, 30 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index b0bb956bb9d1..10e16d6cee78 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -343,14 +343,6 @@ struct amdgpu_ih_funcs {
>  bool amdgpu_get_bios(struct amdgpu_device *adev);
>  bool amdgpu_read_bios(struct amdgpu_device *adev);
>
> -/*
> - * Dummy page
> - */
> -struct amdgpu_dummy_page {
> -       struct page     *page;
> -       dma_addr_t      addr;
> -};
> -
>  /*
>   * Clocks
>   */
> @@ -1508,7 +1500,7 @@ struct amdgpu_device {
>         /* MC */
>         struct amdgpu_gmc               gmc;
>         struct amdgpu_gart              gart;
> -       struct amdgpu_dummy_page        dummy_page;
> +       dma_addr_t                      dummy_page_addr;

Might be cleaner to put dummy_page_addr in the amdgpu_gart struct.  Either way:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>