[PATCH 11/22] drm/amdgpu: Remove the memory leak after unload amdgpu driver

[Liu, Monk]

Hi Alex
This patch works on another branch, and staging looks not need it, my bad

-----Original Message-----
From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf Of Liu, Monk
Sent: 2018年2月27日 13:27
To: Alex Deucher <alexdeucher at gmail.com>
Cc: Deng, Emily <Emily.Deng at amd.com>; amd-gfx list <amd-gfx at lists.freedesktop.org>
Subject: RE: [PATCH 11/22] drm/amdgpu: Remove the memory leak after unload amdgpu driver

I'm sure it is right, the kmemleak is fixed by this patch

-----Original Message-----
From: Alex Deucher [mailto:alexdeucher at gmail.com]
Sent: 2018年2月27日 1:28
To: Liu, Monk <Monk.Liu at amd.com>
Cc: amd-gfx list <amd-gfx at lists.freedesktop.org>; Deng, Emily <Emily.Deng at amd.com>
Subject: Re: [PATCH 11/22] drm/amdgpu: Remove the memory leak after unload amdgpu driver

On Mon, Feb 26, 2018 at 12:18 AM, Monk Liu <Monk.Liu at amd.com> wrote:
> From: Emily Deng <Emily.Deng at amd.com>
>
> Need to call function amdgpu_ucode_fini_bo to release ucode bo for psp 
> firmware load type.

Are you sure this is right?  I think is this is handled in amdgpu_psp.c already.

Alex

>
> Change-Id: I1c7be8135993e11076c9d46b3cd87615514a9abb
> Signed-off-by: Emily Deng <Emily.Deng at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 69fb5e50..61696c7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1490,6 +1490,7 @@ static int amdgpu_device_ip_fini(struct 
> amdgpu_device *adev)
>
>         /* disable all interrupts */
>         amdgpu_irq_disable_all(adev);
> +       amdgpu_ucode_fini_bo(adev);
>
>         for (i = adev->num_ip_blocks - 1; i >= 0; i--) {
>                 if (!adev->ip_blocks[i].status.sw)
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx