[PATCH 10/22] drm/amdgpu: no need to count emitted for SRIOV

[Christian König]

Am 27.02.2018 um 06:26 schrieb Liu, Monk:
>> I would rather avoid calling the function in the first place.
> I already did it in patch 08, and you also rejected this patch
>
> So I'll consider patch 08 is still valid, and drop this one

Well a good part of patch 08 is still valid. I just rejected that you 
want to wait for the create message alone cause that is known to cause 
problems.

But patch 08 is about VCE and this change is about UVD. So you should 
probably go into amdgpu_uvd_ring_end_use() and disable the 
schedule_delayed_work() under SRIOV.

Regards,
Christian.

>
> -----Original Message-----
> From: Christian König [mailto:ckoenig.leichtzumerken at gmail.com]
> Sent: 2018年2月26日 18:09
> To: Liu, Monk <Monk.Liu at amd.com>; amd-gfx at lists.freedesktop.org
> Subject: Re: [PATCH 10/22] drm/amdgpu: no need to count emitted for SRIOV
>
> I would rather avoid calling the function in the first place.
>
> Christian.
>
> Am 26.02.2018 um 06:18 schrieb Monk Liu:
>> Change-Id: I370966acd0f1925a99dfde888678e6e0fd093b15
>> Signed-off-by: Monk Liu <Monk.Liu at amd.com>
>> ---
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +++-
>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> index 337db57..5fb4357 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> @@ -1117,11 +1117,13 @@ static void amdgpu_uvd_idle_work_handler(struct work_struct *work)
>>    {
>>    	struct amdgpu_device *adev =
>>    		container_of(work, struct amdgpu_device, uvd.idle_work.work);
>> -	unsigned fences = amdgpu_fence_count_emitted(&adev->uvd.ring);
>> +	unsigned fences;
>>    
>>    	if (amdgpu_sriov_vf(adev))
>>    		BUG();
>>    
>> +	fences = amdgpu_fence_count_emitted(&adev->uvd.ring);
>> +
>>    	if (fences == 0) {
>>    		if (adev->pm.dpm_enabled) {
>>    			amdgpu_dpm_enable_uvd(adev, false);