[PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

[Michel Dänzer]

On 2018-02-27 10:26 AM, Liu, Monk wrote:
> I'm not familiar with DC stuffs, I found without this patch DRM always reporting error like this:

[...]

> [   89.936514] [drm:drm_helper_disable_unused_functions [drm_kms_helper]] *ERROR* Called for atomic driver, this is not what you want.

"atomic driver" means DC is enabled, in which case
drm_helper_disable_unused_functions shouldn't have been called.

Maybe the issue is that DRIVER_ATOMIC is a driver flag, whereas DC can
be enabled or not per device. See the discussion on
https://patchwork.freedesktop.org/patch/200304/ .

Meanwhile, NAK for this patch.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer