[PATCH libdrm 4/4] test/amdgpu: fix compiler warnings

Christian König ckoenig.leichtzumerken at gmail.com
Sun Jan 7 09:11:35 UTC 2018


SWAP_32() should mask first and then shift.

Signed-off-by: Christian König <christian.koenig at amd.com>
---
 tests/amdgpu/basic_tests.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c
index 474a679c..9c918951 100644
--- a/tests/amdgpu/basic_tests.c
+++ b/tests/amdgpu/basic_tests.c
@@ -253,10 +253,10 @@ CU_TestInfo basic_tests[] = {
 
 
 
-#define SWAP_32(num) ((num>>24)&0xff) | \
-			((num<<8)&0xff0000) | \
-			((num>>8)&0xff00) | \
-			((num<<24)&0xff000000)
+#define SWAP_32(num) (((num & 0xff000000) >> 24) | \
+		      ((num & 0x0000ff00) << 8) | \
+		      ((num & 0x00ff0000) >> 8) | \
+		      ((num & 0x000000ff) << 24))
 
 
 /* Shader code
-- 
2.11.0



More information about the amd-gfx mailing list