[PATCH] Fix pde_copy/pde_array initialisation

Tom St Denis tom.stdenis at amd.com
Tue Jan 23 14:09:24 UTC 2018


Thanks, I RB'ed and pushed it out.

On 23/01/18 08:55 AM, Christian König wrote:
> All zero is a perfectly valid value for a PDE.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>   src/lib/read_vram.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c
> index 3331b3e..25ffec9 100644
> --- a/src/lib/read_vram.c
> +++ b/src/lib/read_vram.c
> @@ -136,7 +136,7 @@ static int umr_access_vram_vi(struct umr_asic *asic, uint32_t vmid,
>   	unsigned char *pdst = dst;
>   
>   	memset(&registers, 0, sizeof registers);
> -	memset(&pde_copy, 0, sizeof pde_copy);
> +	memset(&pde_copy, 0xff, sizeof pde_copy);
>   
>   	/*
>   	 * PTE format on VI:
> @@ -357,7 +357,7 @@ static int umr_access_vram_ai(struct umr_asic *asic, uint32_t vmid,
>   	static const char *indentation = "            \\->";
>   
>   	memset(&registers, 0, sizeof registers);
> -	memset(&pde_array, 0, sizeof pde_array);
> +	memset(&pde_array, 0xff, sizeof pde_array);
>   
>   	/*
>   	 * PTE format on AI:
> 



More information about the amd-gfx mailing list