[PATCH] drm/amdgpu: Avoid leaking PM domain on driver unbind

Lukas Wunner lukas at wunner.de
Tue Jan 23 14:53:48 UTC 2018


On Mon, Jan 22, 2018 at 11:22:58PM -0500, Alex Deucher wrote:
> On Sun, Jan 21, 2018 at 7:46 AM, Lukas Wunner <lukas at wunner.de> wrote:
> > amdgpu_device_init() calls vga_switcheroo_init_domain_pm_ops() either
> > if the device has the PowerXpress flag set or if the user has set the
> > "runpm" module param to 1.
> >
> > However amdgpu_device_fini() calls vga_switcheroo_fini_domain_pm_ops()
> > only under the first of those two conditions.
> 
> Good catch.  Forcing runpm=1 doesn't do anything useful anyway so just
> remove it in device_init().  See the attached patch.

Ok, ack.

Lukas


More information about the amd-gfx mailing list