[PATCH libdrm] drm/amdgpu: define amdgpu_syncobj_handle type for vulkan usage

Christian König ckoenig.leichtzumerken at gmail.com
Wed Jan 24 10:55:50 UTC 2018


Am 24.01.2018 um 07:19 schrieb Seth Zhu:
> Vulkan Fence and Semaphore(AMDVLK) will add implementation based on
> sync object. Semantic syncobj handle type is required instead of
> using uint32_t directly.

As I already wrote to David I don't think that this is a good idea.

The sync object is a general DRM object and nothing amdgpu specific.

Regards,
Christian.

>
> Change-Id: Idbd2b2b161818fa58fe0bb3d1ac46453847ae626
> Signed-off-by: Seth Zhu <seth.zhu at amd.com>
> ---
>   amdgpu/amdgpu.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
> index 9ef55e5..31fc201 100644
> --- a/amdgpu/amdgpu.h
> +++ b/amdgpu/amdgpu.h
> @@ -145,6 +145,10 @@ typedef struct amdgpu_semaphore *amdgpu_semaphore_handle;
>    * Define handle for sem file
>    */
>   typedef uint32_t amdgpu_sem_handle;
> +/**
> + * Define handle for syncobj
> + */
> +typedef uint32_t amdgpu_syncobj_handle;
>   
>   
>   /*--------------------------------------------------------------------------*/



More information about the amd-gfx mailing list