[PATCH 2/2] drm/amdgpu: remove WARN_ON when VM isn't found

[Alex Deucher]

On Wed, Jan 24, 2018 at 7:39 AM, Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
> It can easily be that the VM is already destroyed when this runs.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
> index 9589e0a2f14a..ee7e16d576c0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
> @@ -278,7 +278,7 @@ static bool vega10_ih_prescreen_iv(struct amdgpu_device *adev)
>         /* Track retry faults in per-VM fault FIFO. */
>         spin_lock(&adev->vm_manager.pasid_lock);
>         vm = idr_find(&adev->vm_manager.pasid_idr, pasid);
> -       if (WARN_ON_ONCE(!vm)) {
> +       if (vm) {

Should be !vm.  With that fixed:
Acked-by: Alex Deucher <alexander.deucher at amd.com>


>                 /* VM not found, process it normally */
>                 spin_unlock(&adev->vm_manager.pasid_lock);
>                 amdgpu_ih_clear_fault(adev, key);
> --
> 2.14.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx