[PATCH 1/6] drm/amdgpu/pm: handle fan properly when card is powered down

[Christian König]

Am 25.01.2018 um 00:55 schrieb Alex Deucher:
> Return an error if the user tried to check or set the fan
> parameters while the card is powered down (e.g., on a PX/HG
> system for example).  This makes the fan consistent with the
> temperature stuff.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Acked-by: Christian König <christian.koenig at amd.com> for the series.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> index fda858ec3cad..18873c2286f9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> @@ -991,6 +991,11 @@ static ssize_t amdgpu_hwmon_set_pwm1_enable(struct device *dev,
>   	int err;
>   	int value;
>   
> +	/* Can't adjust fan when the card is off */
> +	if  ((adev->flags & AMD_IS_PX) &&
> +	     (adev->ddev->switch_power_state != DRM_SWITCH_POWER_ON))
> +		return -EINVAL;
> +
>   	if (!adev->powerplay.pp_funcs->set_fan_control_mode)
>   		return -EINVAL;
>   
> @@ -1025,6 +1030,11 @@ static ssize_t amdgpu_hwmon_set_pwm1(struct device *dev,
>   	int err;
>   	u32 value;
>   
> +	/* Can't adjust fan when the card is off */
> +	if  ((adev->flags & AMD_IS_PX) &&
> +	     (adev->ddev->switch_power_state != DRM_SWITCH_POWER_ON))
> +		return -EINVAL;
> +
>   	err = kstrtou32(buf, 10, &value);
>   	if (err)
>   		return err;
> @@ -1048,6 +1058,11 @@ static ssize_t amdgpu_hwmon_get_pwm1(struct device *dev,
>   	int err;
>   	u32 speed = 0;
>   
> +	/* Can't adjust fan when the card is off */
> +	if  ((adev->flags & AMD_IS_PX) &&
> +	     (adev->ddev->switch_power_state != DRM_SWITCH_POWER_ON))
> +		return -EINVAL;
> +
>   	if (adev->powerplay.pp_funcs->get_fan_speed_percent) {
>   		err = amdgpu_dpm_get_fan_speed_percent(adev, &speed);
>   		if (err)
> @@ -1067,6 +1082,11 @@ static ssize_t amdgpu_hwmon_get_fan1_input(struct device *dev,
>   	int err;
>   	u32 speed = 0;
>   
> +	/* Can't adjust fan when the card is off */
> +	if  ((adev->flags & AMD_IS_PX) &&
> +	     (adev->ddev->switch_power_state != DRM_SWITCH_POWER_ON))
> +		return -EINVAL;
> +
>   	if (adev->powerplay.pp_funcs->get_fan_speed_rpm) {
>   		err = amdgpu_dpm_get_fan_speed_rpm(adev, &speed);
>   		if (err)