[PATCH v2] drm/amdgpu: Redefine the bit PP_OVERDRIVE_MASK for PP_FEATURES

[Alex Deucher]

On Tue, Jan 30, 2018 at 3:24 AM, Rex Zhu <Rex.Zhu at amd.com> wrote:
> For feature enabled by default, define its bit mask from low bit
> For feature disabled by default, define its bit mask from high bit.
>
> Change-Id: Iaa9ea6306a57b73bd3481fa152f0f01794a88427
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c   | 2 +-
>  drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index d1a6958..7f08777 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -121,7 +121,7 @@
>  uint amdgpu_sdma_phase_quantum = 32;
>  char *amdgpu_disable_cu = NULL;
>  char *amdgpu_virtual_display = NULL;
> -uint amdgpu_pp_feature_mask = 0x3fff;
> +uint amdgpu_pp_feature_mask = 0x7fffffff;
>  int amdgpu_ngg = 0;
>  int amdgpu_prim_buf_per_se = 0;
>  int amdgpu_pos_buf_per_se = 0;
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> index 5512dc2..3ad45ac 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> @@ -84,7 +84,7 @@ enum PP_FEATURE_MASK {
>         PP_OD_FUZZY_FAN_CONTROL_MASK = 0x800,
>         PP_SOCCLK_DPM_MASK = 0x1000,
>         PP_DCEFCLK_DPM_MASK = 0x2000,
> -       PP_OVERDRIVE_MASK = 0x4000,
> +       PP_OVERDRIVE_MASK = 0x80000000, /* disabled by default */

If an option is eventually enabled by default, is the intention that
we move it down to the other side?  I don't really see much value in
this patch.  Better to just adjust the default flags as necessary as
we enable things so the flag bits stay consistent.

Alex

>  };
>
>  enum PHM_BackEnd_Magic {
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx