[PATCH] drm/amdgpu: Add AMDGPU_GPU_PAGES_IN_CPU_PAGE define

[Christian König]

Am 25.06.2018 um 16:41 schrieb Alex Deucher:
> On Mon, Jun 25, 2018 at 9:33 AM, Zhou, David(ChunMing)
> <David1.Zhou at amd.com> wrote:
>> current amdgpu driver indeed always set GPU PAGE SIZE is 4096.
>> In fact, our gpu supports bigger page size like 64KB, just we don't use it.
>> I remeber previous amdsoc(old android kernel driver) used 64KB.
>>
>> correct me if I'm wrong.
> It's still 4k pages, but you can tweak the fragment size to make a TLB
> entry cover multiple pages.

Yeah, but David is right you can also directly increase the GPU page 
size. It's just that I'm pretty sure we will never ever support that :)

Anyway original patch is Reviewed-by: Christian König 
<christian.koenig at amd.com>.

Christian.

>
> Alex
>
>> send from Smartisan Pro
>>
>> Michel D鋘zer <michel at daenzer.net> 于 2018年6月25日 下午5:10写道：
>>
>> On 2018-06-25 03:56 AM, zhoucm1 wrote:
>>> one question to you:
>>>
>>> Did you consider the case that GPU_PAGE_SIZE > CPU_PAGE_SIZE?
>> That is never the case: AMDGPU_GPU_PAGE_SIZE is always 4096, and
>> PAGE_SIZE is always >= 4096 (an integer multiple of it).
>>
>>
>> --
>> Earthling Michel Dänzer               |               http://www.amd.com
>> Libre software enthusiast             |             Mesa and X developer
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx