SOC15 DC support warning

Tom St Denis tstdenis at amd.com
Tue Jul 3 14:19:33 UTC 2018


Hi all,

This block

#if defined(CONFIG_DRM_AMD_DC)
		else if (amdgpu_device_has_dc_support(adev))
			amdgpu_device_ip_block_add(adev, &dm_ip_block);
#else
#	warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15."
#endif


in soc15_set_ip_blocks() should probably be ported to a runtime 
drm_warn() no?  This means a kernel with no DC support will just 
silently fail to light up on SOC15.

I can write a patch for this if nobody objects.

(found this while trying to sort out the PP get_clocks call for my 
Raven1 ...).

Tom


More information about the amd-gfx mailing list