Re: 答复: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message

[Christian König]

Reviewed-by: Christian König <christian.koenig at amd.com>

Am 06.07.2018 um 05:12 schrieb Qu, Jim:
> Reviewed-by: Jim Qu <Jim.Qu at amd.com>
>
> Thanks
> JimQu
>
> ________________________________________
> 发件人: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> 代表 Alex Deucher <alexdeucher at gmail.com>
> 发送时间: 2018年7月6日 4:46:33
> 收件人: amd-gfx at lists.freedesktop.org
> 抄送: Deucher, Alexander
> 主题: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message
>
> Switching the firmware paths for CIK parts resulted
> in no need for this anymore.
>
> Fixes: "drm/amdgpu: switch firmware path for CIK parts"
> Noticed-by: Julia Lawall <Julia.Lawall at lip6.fr>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> index 2c2b93d4d63b..78339309a00c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> @@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev)
>          default: BUG();
>          }
>
> -       if (adev->asic_type == CHIP_TOPAZ)
> -               snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
> -       else
> -               snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
> +       snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
>
>          err = request_firmware(&adev->gmc.fw, fw_name, adev->dev);
>          if (err)
> --
> 2.13.6
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx