[PATCH] drm/amdgpu/gmc7: simplify logic in firmware message

Huang Rui ray.huang at amd.com
Fri Jul 6 09:57:38 UTC 2018


On Thu, Jul 05, 2018 at 03:46:33PM -0500, Alex Deucher wrote:
> Switching the firmware paths for CIK parts resulted
> in no need for this anymore.
> 
> Fixes: "drm/amdgpu: switch firmware path for CIK parts"
> Noticed-by: Julia Lawall <Julia.Lawall at lip6.fr>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Reviewed-by: Huang Rui <ray.huang at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> index 2c2b93d4d63b..78339309a00c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> @@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev)
>  	default: BUG();
>  	}
>  
> -	if (adev->asic_type == CHIP_TOPAZ)
> -		snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
> -	else
> -		snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
> +	snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
>  
>  	err = request_firmware(&adev->gmc.fw, fw_name, adev->dev);
>  	if (err)
> -- 
> 2.13.6
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list