[PATCH 1/3] drm/amdgpu/pp: remove dead vega12 code

[Christian König]

Am 12.07.2018 um 22:23 schrieb Alex Deucher:
> Commented out.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Acked-by: Christian König <christian.koenig at amd.com>

> ---
>   .../gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c   | 29 ----------------------
>   1 file changed, 29 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> index 7d9b40e8b1bf..508a262fb328 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> @@ -343,29 +343,6 @@ static int vega12_set_tools_address(struct pp_hwmgr *hwmgr)
>   	return 0;
>   }
>   
> -#if 0 /* tentatively remove */
> -static int vega12_verify_smc_interface(struct pp_hwmgr *hwmgr)
> -{
> -	uint32_t smc_driver_if_version;
> -
> -	PP_ASSERT_WITH_CODE(!vega12_send_msg_to_smc(hwmgr,
> -			PPSMC_MSG_GetDriverIfVersion),
> -			"Attempt to get SMC IF Version Number Failed!",
> -			return -EINVAL);
> -	vega12_read_arg_from_smc(hwmgr, &smc_driver_if_version);
> -
> -	if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
> -		pr_err("Your firmware(0x%x) doesn't match \
> -			SMU9_DRIVER_IF_VERSION(0x%x). \
> -			Please update your firmware!\n",
> -			smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
> -		return -EINVAL;
> -	}
> -
> -	return 0;
> -}
> -#endif
> -
>   static int vega12_smu_init(struct pp_hwmgr *hwmgr)
>   {
>   	struct vega12_smumgr *priv;
> @@ -517,12 +494,6 @@ static int vega12_start_smu(struct pp_hwmgr *hwmgr)
>   			"SMC is not running!",
>   			return -EINVAL);
>   
> -#if 0 /* tentatively remove */
> -	PP_ASSERT_WITH_CODE(!vega12_verify_smc_interface(hwmgr),
> -			"Failed to verify SMC interface!",
> -			return -EINVAL);
> -#endif
> -
>   	vega12_set_tools_address(hwmgr);
>   
>   	return 0;