[PATCH xf86-video-amdgpu] Hardcode "non-desktop" RandR property name

Yu, Qiang Qiang.Yu at amd.com
Mon Jul 16 02:16:42 UTC 2018


Thanks, looks good for me.
Reviewed-by: Qiang Yu <Qiang.Yu at amd.com>

Regards,
Qiang

________________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Michel Dänzer <michel at daenzer.net>
Sent: Friday, July 13, 2018 4:41:51 PM
To: amd-gfx at lists.freedesktop.org
Subject: [PATCH xf86-video-amdgpu] Hardcode "non-desktop" RandR property name

From: Michel Dänzer <michel.daenzer at amd.com>

It's a bit silly to require current randrproto just for this definition,
which can't really change anyway.

Suggested-by: Qiang Yu <qiang.yu at amd.com>
Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
---
 configure.ac          | 2 +-
 src/drmmode_display.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index f4633e370..1ab5a7ae2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -64,7 +64,7 @@ AC_ARG_WITH(xorg-module-dir,
             [moduledir="$libdir/xorg/modules"])

 # Store the list of server defined optional extensions in REQUIRED_MODULES
-XORG_DRIVER_CHECK_EXT(RANDR, [randrproto >= 1.6.0])
+XORG_DRIVER_CHECK_EXT(RANDR, randrproto)
 XORG_DRIVER_CHECK_EXT(RENDER, renderproto)
 XORG_DRIVER_CHECK_EXT(XV, videoproto)
 XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
diff --git a/src/drmmode_display.c b/src/drmmode_display.c
index f6cafccdc..ccf333662 100644
--- a/src/drmmode_display.c
+++ b/src/drmmode_display.c
@@ -2634,7 +2634,7 @@ drmmode_output_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, drmModeResPtr mode_r

 #if XF86_CRTC_VERSION >= 8
        i = koutput_get_prop_idx(pAMDGPUEnt->fd, koutput, DRM_MODE_PROP_RANGE,
-                                RR_PROPERTY_NON_DESKTOP);
+                                "non-desktop");
        if (i >= 0)
                nonDesktop = koutput->prop_values[i] != 0;
 #endif
--
2.18.0

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list