kfd kfd: DID 15dd is missing in supported_devices

[Paul Menzel]

Dear AMD Linux folks,


Using Linux 4.18.0-rc5+ I get the warning and error below in the logs.
I am using a Ryzen 3 2200g.

```
$ dmesg
[    0.000000] Linux version 4.18.0-rc5+ (paul at tokeiihto) (gcc version 8.1.0 (Debian 8.1.0-10)) #1 SMP Tue Jul 17 11:43:33 CEST 2018
[    0.000000] Command line: BOOT_IMAGE=/vmlinuz-4.18.0-rc5+ root=UUID=313f78e2-468f-4660-b236-d1de214bf6b4 ro noisapnp cryptomgr.notests apparmor=0 log_buf_len=4M initcall_debug quiet
[…]
[   24.263395] calling  kfd_module_init+0x0/0x1000 [amdkfd] @ 411
[   24.263441] Parsing CRAT table with 1 nodes
[   24.263451] Creating topology SYSFS entries
[   24.263480] Topology: Add APU node [0x0:0x0]
[   24.263480] Finished initializing topology
[   24.263503] kfd kfd: Initialized module
[   24.263510] initcall kfd_module_init+0x0/0x1000 [amdkfd] returned 0 after 104 usecs
[…]
[   24.266813] kfd kfd: DID 15dd is missing in supported_devices
[   24.266815] kfd kfd: kgd2kfd_probe failed
[…]
```

The messages are from the code below.

```
$ vim drivers/gpu/drm/amd/amdkfd/kfd_device.c
[…]
305 static const struct kfd_device_info *lookup_device_info(unsigned short did)
306 {
307         size_t i;
308 
309         for (i = 0; i < ARRAY_SIZE(supported_devices); i++) {
310                 if (supported_devices[i].did == did) {
311                         WARN_ON(!supported_devices[i].device_info);
312                         return supported_devices[i].device_info;
313                 }
314         }
315 
316         dev_warn(kfd_device, "DID %04x is missing in supported_devices\n",
317                  did);
318 
319         return NULL;
320 }
321 
322 struct kfd_dev *kgd2kfd_probe(struct kgd_dev *kgd,
323         struct pci_dev *pdev, const struct kfd2kgd_calls *f2g)
324 {
325         struct kfd_dev *kfd;
326         int ret;
327         const struct kfd_device_info *device_info =
328                                         lookup_device_info(pdev->device);
329 
330         if (!device_info) {
331                 dev_err(kfd_device, "kgd2kfd_probe failed\n");
332                 return NULL;
333         }
[…]
```

Can my ID just be added? Otherwise, if it’s expected that the probe function
can fail, the log level shouldn’t be an error?

Maybe something like below would be more clear, that it is expected.

> DID 15dd is missing in supported_devices and not supported yet.


Kind regards,

Paul

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5174 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180717/5171232b/attachment.bin>