[PATCH] drm/amd/display: Honor pplib stutter mask for all ASICs in DC

[Alex Deucher]

On Tue, Jul 17, 2018 at 10:54 AM, Harry Wentland <harry.wentland at amd.com> wrote:
> [Why]
> We were only setting this mask for DCN, but should really use it
> universally for all ASICs.
>
> [How]
> Move the assignment out of the Raven switch statement.
>
> Cc: Rex.Zhu at amd.com
> Cc: Feifei.Xu at amd.com
> Cc: Kenneth.Feng at amd.com
> Cc: Evan.Quan at amd.com
> Cc: Bhawanpreet.Lakha at amd.com
> Cc: Jordan.Lazare at amd.com
> Signed-off-by: Harry Wentland <harry.wentland at amd.com>

I thought we had previously enabled stutter for CZ.  Does that use a
different path or was the code reworked in the interim?

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 952691c6f81e..004636ead29b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1528,10 +1528,6 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
>                         DRM_ERROR("DM: Failed to initialize IRQ\n");
>                         goto fail;
>                 }
> -               /*
> -                * Temporary disable until pplib/smu interaction is implemented
> -                */
> -               dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask & PP_STUTTER_MODE ? false : true;
>                 break;
>  #endif
>         default:
> @@ -1539,6 +1535,8 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
>                 goto fail;
>         }
>
> +       dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask & PP_STUTTER_MODE ? false : true;
> +
>         return 0;
>  fail:
>         kfree(aencoder);
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx