[PATCH] drm/amdgpu: remove internal/unused kernel module parameters

[Alex Deucher]

On Tue, Jul 17, 2018 at 3:35 PM, Sonny Jiang <sonny.jiang at amd.com> wrote:
> Signed-off-by: Sonny Jiang <sonny.jiang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h     |  4 ----
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 16 ----------------
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c |  6 ------
>  3 files changed, 26 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index d852d11..e15fa64 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -106,11 +106,8 @@ extern int amdgpu_vm_fault_stop;
>  extern int amdgpu_vm_debug;
>  extern int amdgpu_vm_update_mode;
>  extern int amdgpu_dc;
> -extern int amdgpu_dc_log;
>  extern int amdgpu_sched_jobs;
>  extern int amdgpu_sched_hw_submission;
> -extern int amdgpu_no_evict;
> -extern int amdgpu_direct_gma_size;
>  extern uint amdgpu_pcie_gen_cap;
>  extern uint amdgpu_pcie_lane_cap;
>  extern uint amdgpu_cg_mask;
> @@ -127,7 +124,6 @@ extern int amdgpu_cntl_sb_buf_per_se;
>  extern int amdgpu_param_buf_per_se;
>  extern int amdgpu_job_hang_limit;
>  extern int amdgpu_lbpw;
> -extern int amdgpu_compute_multipipe;
>  extern int amdgpu_gpu_recovery;
>  extern int amdgpu_emu_mode;
>  extern uint amdgpu_smu_memory_pool_size;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 529500c..de8a2ee 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -104,11 +104,8 @@ int amdgpu_vram_page_split = 512;
>  int amdgpu_vm_update_mode = -1;
>  int amdgpu_exp_hw_support = 0;
>  int amdgpu_dc = -1;
> -int amdgpu_dc_log = 0;
>  int amdgpu_sched_jobs = 32;
>  int amdgpu_sched_hw_submission = 2;
> -int amdgpu_no_evict = 0;
> -int amdgpu_direct_gma_size = 0;
>  uint amdgpu_pcie_gen_cap = 0;
>  uint amdgpu_pcie_lane_cap = 0;
>  uint amdgpu_cg_mask = 0xffffffff;
> @@ -125,7 +122,6 @@ int amdgpu_cntl_sb_buf_per_se = 0;
>  int amdgpu_param_buf_per_se = 0;
>  int amdgpu_job_hang_limit = 0;
>  int amdgpu_lbpw = -1;
> -int amdgpu_compute_multipipe = -1;
>  int amdgpu_gpu_recovery = -1; /* auto */
>  int amdgpu_emu_mode = 0;
>  uint amdgpu_smu_memory_pool_size = 0;
> @@ -341,9 +337,6 @@ module_param_named(exp_hw_support, amdgpu_exp_hw_support, int, 0444);
>  MODULE_PARM_DESC(dc, "Display Core driver (1 = enable, 0 = disable, -1 = auto (default))");
>  module_param_named(dc, amdgpu_dc, int, 0444);
>
> -MODULE_PARM_DESC(dc_log, "Display Core Log Level (0 = minimal (default), 1 = chatty");
> -module_param_named(dc_log, amdgpu_dc_log, int, 0444);
> -
>  /**
>   * DOC: sched_jobs (int)
>   * Override the max number of jobs supported in the sw queue. The default is 32.
> @@ -366,12 +359,6 @@ module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444);
>  MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))");
>  module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, uint, 0444);
>
> -MODULE_PARM_DESC(no_evict, "Support pinning request from user space (1 = enable, 0 = disable (default))");
> -module_param_named(no_evict, amdgpu_no_evict, int, 0444);
> -
> -MODULE_PARM_DESC(direct_gma_size, "Direct GMA size in megabytes (max 96MB)");
> -module_param_named(direct_gma_size, amdgpu_direct_gma_size, int, 0444);
> -
>  /**
>   * DOC: pcie_gen_cap (uint)
>   * Override PCIE gen speed capabilities. See the CAIL flags in drivers/gpu/drm/amd/include/amd_pcie.h.
> @@ -478,9 +465,6 @@ module_param_named(job_hang_limit, amdgpu_job_hang_limit, int ,0444);
>  MODULE_PARM_DESC(lbpw, "Load Balancing Per Watt (LBPW) support (1 = enable, 0 = disable, -1 = auto)");
>  module_param_named(lbpw, amdgpu_lbpw, int, 0444);
>
> -MODULE_PARM_DESC(compute_multipipe, "Force compute queues to be spread across pipes (1 = enable, 0 = disable, -1 = auto)");
> -module_param_named(compute_multipipe, amdgpu_compute_multipipe, int, 0444);
> -
>  /**
>   * DOC: gpu_recovery (int)
>   * Set to enable GPU recovery mechanism (1 = enable, 0 = disable). The default is -1 (auto, disabled except SRIOV).
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index 239bf2a..581959a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -111,12 +111,6 @@ void amdgpu_gfx_parse_disable_cu(unsigned *mask, unsigned max_se, unsigned max_s
>
>  static bool amdgpu_gfx_is_multipipe_capable(struct amdgpu_device *adev)
>  {
> -       if (amdgpu_compute_multipipe != -1) {
> -               DRM_INFO("amdgpu: forcing compute pipe policy %d\n",
> -                        amdgpu_compute_multipipe);
> -               return amdgpu_compute_multipipe == 1;
> -       }
> -

Looks like this option is not actually unused.  We should keep this one for now.

Alex

>         /* FIXME: spreading the queues across pipes causes perf regressions
>          * on POLARIS11 compute workloads */
>         if (adev->asic_type == CHIP_POLARIS11)
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx