[PATCH] drm/amdgpu: reduce the number of placements for a BO

[Huang Rui]

On Wed, Jul 18, 2018 at 11:17:56AM +0200, Christian König wrote:
> Make struct amdgpu_bo a bit smaller.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>

Reviewed-by: Huang Rui <ray.huang at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 ++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 45367df96855..500121ad513c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -216,6 +216,8 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)
>  		c++;
>  	}
>  
> +	BUG_ON(c >= AMDGPU_BO_MAX_PLACEMENTS);
> +
>  	placement->num_placement = c;
>  	placement->placement = places;
>  
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> index 345fcd176992..18945dd6982d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> @@ -32,6 +32,7 @@
>  #include "amdgpu.h"
>  
>  #define AMDGPU_BO_INVALID_OFFSET	LONG_MAX
> +#define AMDGPU_BO_MAX_PLACEMENTS	3
>  
>  struct amdgpu_bo_param {
>  	unsigned long			size;
> @@ -77,7 +78,7 @@ struct amdgpu_bo {
>  	/* Protected by tbo.reserved */
>  	u32				preferred_domains;
>  	u32				allowed_domains;
> -	struct ttm_place		placements[AMDGPU_GEM_DOMAIN_MAX + 1];
> +	struct ttm_place		placements[AMDGPU_BO_MAX_PLACEMENTS];
>  	struct ttm_placement		placement;
>  	struct ttm_buffer_object	tbo;
>  	struct ttm_bo_kmap_obj		kmap;
> -- 
> 2.14.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx