[PATCH] drm/amd/display: Drop unused backlight functions in DM

[Alex Deucher]

On Thu, Jul 19, 2018 at 2:28 PM, Harry Wentland <harry.wentland at amd.com> wrote:
> These are only ever called for non-DC code.
>
> Signed-off-by: Harry Wentland <harry.wentland at amd.com>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  | 18 ++----------------
>  1 file changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 004636ead29b..205c62903050 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1568,18 +1568,6 @@ static void dm_bandwidth_update(struct amdgpu_device *adev)
>         /* TODO: implement later */
>  }
>
> -static void dm_set_backlight_level(struct amdgpu_encoder *amdgpu_encoder,
> -                                    u8 level)
> -{
> -       /* TODO: translate amdgpu_encoder to display_index and call DAL */
> -}
> -
> -static u8 dm_get_backlight_level(struct amdgpu_encoder *amdgpu_encoder)
> -{
> -       /* TODO: translate amdgpu_encoder to display_index and call DAL */
> -       return 0;
> -}
> -
>  static int amdgpu_notify_freesync(struct drm_device *dev, void *data,
>                                 struct drm_file *filp)
>  {
> @@ -1654,10 +1642,8 @@ static int amdgpu_notify_freesync(struct drm_device *dev, void *data,
>  static const struct amdgpu_display_funcs dm_display_funcs = {
>         .bandwidth_update = dm_bandwidth_update, /* called unconditionally */
>         .vblank_get_counter = dm_vblank_get_counter,/* called unconditionally */
> -       .backlight_set_level =
> -               dm_set_backlight_level,/* called unconditionally */
> -       .backlight_get_level =
> -               dm_get_backlight_level,/* called unconditionally */
> +       .backlight_set_level = NULL, /* never called for DC */
> +       .backlight_get_level = NULL, /* never called for DC */
>         .hpd_sense = NULL,/* called unconditionally */
>         .hpd_set_polarity = NULL, /* called unconditionally */
>         .hpd_get_gpio_reg = NULL, /* VBIOS parsing. DAL does it. */
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx