[PATCH 2/3] drm/amd/powerplay: correct the argument for PPSMC_MSG_SetUclkFastSwitch

Quan, Evan Evan.Quan at amd.com
Mon Jul 23 06:38:55 UTC 2018


Ping ..

> -----Original Message-----
> From: Evan Quan <evan.quan at amd.com>
> Sent: Friday, July 20, 2018 10:35 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Zhu, Rex <Rex.Zhu at amd.com>; Quan, Evan <Evan.Quan at amd.com>
> Subject: [PATCH 2/3] drm/amd/powerplay: correct the argument for
> PPSMC_MSG_SetUclkFastSwitch
> 
> The argument was set wrongly. Fast/slow switch was asked when there is
> actually a slow/fast switch needed.
> 
> Change-Id: Ibcfdf741dea1700cc3796f84291606231e732f4b
> Signed-off-by: Evan Quan <evan.quan at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +-
> drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index bf7b8cfebe2b..002ed77a5268 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -3705,7 +3705,7 @@ static void
> vega10_notify_smc_display_change(struct pp_hwmgr *hwmgr,  {
>  	smum_send_msg_to_smc_with_parameter(hwmgr,
>  			PPSMC_MSG_SetUclkFastSwitch,
> -			has_disp ? 0 : 1);
> +			has_disp ? 1 : 0);
>  }
> 
>  int vega10_display_clock_voltage_request(struct pp_hwmgr *hwmgr, diff --
> git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> index 4ed218dd8ba7..35f96dacb50a 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> @@ -1334,7 +1334,7 @@ static int vega12_notify_smc_display_change(struct
> pp_hwmgr *hwmgr,
>  	if (data->smu_features[GNLD_DPM_UCLK].enabled)
>  		return smum_send_msg_to_smc_with_parameter(hwmgr,
>  			PPSMC_MSG_SetUclkFastSwitch,
> -			has_disp ? 0 : 1);
> +			has_disp ? 1 : 0);
> 
>  	return 0;
>  }
> --
> 2.18.0



More information about the amd-gfx mailing list