[PATCH 2/2] drm/amdgpu: fix a reversed condition

Alex Deucher alexdeucher at gmail.com
Wed Jul 25 14:58:45 UTC 2018


On Wed, Jul 25, 2018 at 1:03 AM, Rex Zhu <rex.zhu at amd.com> wrote:
> This test was reversed so it would end up leading to vddnb value
> can't be read on APU.
>
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> index 15a1192..23fc1d3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> @@ -1185,7 +1185,7 @@ static ssize_t amdgpu_hwmon_show_vddnb(struct device *dev,
>         int r, size = sizeof(vddnb);
>
>         /* only APUs have vddnb */
> -       if  (adev->flags & AMD_IS_APU)
> +       if  (!(adev->flags & AMD_IS_APU))
>                 return -EINVAL;
>
>         /* Can't get voltage when the card is off */
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list