[PATCH 2/2] drm/amd/powerplay: remove uncessary extra gfxoff control call

Huang Rui ray.huang at amd.com
Tue Jun 12 11:36:08 UTC 2018


On Tue, Jun 12, 2018 at 05:07:44PM +0800, Evan Quan wrote:
> Gfxoff is already enabled in amdgpu_device_ip_set_powergating_state.
> So, no need to enable it again in pp_late_init.
> 
> Change-Id: Id33d2dac192645fc9dcdfaf5825420093a87f814
> Signed-off-by: Evan Quan <evan.quan at amd.com>

Reviewed-by: Huang Rui <ray.huang at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> index 0969b65..c6aa7d0 100644
> --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> @@ -191,14 +191,6 @@ static int pp_late_init(void *handle)
>  	if (adev->pm.smu_prv_buffer_size != 0)
>  		pp_reserve_vram_for_smu(adev);
>  
> -	if (hwmgr && hwmgr->hwmgr_func &&
> -	    hwmgr->hwmgr_func->gfx_off_control &&
> -	    (hwmgr->feature_mask & PP_GFXOFF_MASK)) {
> -		ret = hwmgr->hwmgr_func->gfx_off_control(hwmgr, true);
> -		if (ret)
> -			pr_err("gfx off enabling failed!\n");
> -	}
> -
>  	return 0;
>  }
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list