[PATCH 12/51] drm/amd/display: Use local structs instead of struct pointers
Harry Wentland
harry.wentland at amd.com
Tue Jun 19 21:10:19 UTC 2018
From: Mikita Lipski <mikita.lipski at amd.com>
Change struct pointers to creating structs on a stack.
Thats fixing a mistake in a previous patch introducing dm_pplib functions
Change-Id: Ibd7960f5ccfcc8a9377ad8dbc8bd2f81e75d30d7
Signed-off-by: Mikita Lipski <mikita.lipski at amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng at amd.com>
Acked-by: Harry Wentland <harry.wentland at amd.com>
---
.../display/amdgpu_dm/amdgpu_dm_services.c | 22 +++++++++----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c
index 0c720e50ea43..67f1245e70ef 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c
@@ -430,31 +430,31 @@ bool dm_pp_apply_clock_for_voltage_request(
struct dm_pp_clock_for_voltage_req *clock_for_voltage_req)
{
struct amdgpu_device *adev = ctx->driver_context;
- struct pp_display_clock_request *pp_clock_request = {0};
+ struct pp_display_clock_request pp_clock_request = {0};
int ret = 0;
switch (clock_for_voltage_req->clk_type) {
case DM_PP_CLOCK_TYPE_DISPLAY_CLK:
- pp_clock_request->clock_type = amd_pp_disp_clock;
+ pp_clock_request.clock_type = amd_pp_disp_clock;
break;
case DM_PP_CLOCK_TYPE_DCEFCLK:
- pp_clock_request->clock_type = amd_pp_dcef_clock;
+ pp_clock_request.clock_type = amd_pp_dcef_clock;
break;
case DM_PP_CLOCK_TYPE_PIXELCLK:
- pp_clock_request->clock_type = amd_pp_pixel_clock;
+ pp_clock_request.clock_type = amd_pp_pixel_clock;
break;
default:
return false;
}
- pp_clock_request->clock_freq_in_khz = clock_for_voltage_req->clocks_in_khz;
+ pp_clock_request.clock_freq_in_khz = clock_for_voltage_req->clocks_in_khz;
if (adev->powerplay.pp_funcs->display_clock_voltage_request)
ret = adev->powerplay.pp_funcs->display_clock_voltage_request(
adev->powerplay.pp_handle,
- pp_clock_request);
+ &pp_clock_request);
if (ret)
return false;
return true;
@@ -465,19 +465,19 @@ bool dm_pp_get_static_clocks(
struct dm_pp_static_clock_info *static_clk_info)
{
struct amdgpu_device *adev = ctx->driver_context;
- struct amd_pp_clock_info *pp_clk_info = {0};
+ struct amd_pp_clock_info pp_clk_info = {0};
int ret = 0;
if (adev->powerplay.pp_funcs->get_current_clocks)
ret = adev->powerplay.pp_funcs->get_current_clocks(
adev->powerplay.pp_handle,
- pp_clk_info);
+ &pp_clk_info);
if (ret)
return false;
- static_clk_info->max_clocks_state = pp_clk_info->max_clocks_state;
- static_clk_info->max_mclk_khz = pp_clk_info->max_memory_clock;
- static_clk_info->max_sclk_khz = pp_clk_info->max_engine_clock;
+ static_clk_info->max_clocks_state = pp_clk_info.max_clocks_state;
+ static_clk_info->max_mclk_khz = pp_clk_info.max_memory_clock;
+ static_clk_info->max_sclk_khz = pp_clk_info.max_engine_clock;
return true;
}
--
2.17.1
More information about the amd-gfx
mailing list