[PATCH 1/1] Fix undefined behaviour from signed integer overflow

Timothy Pearson tpearson at raptorengineering.com
Sat Jun 23 23:58:28 UTC 2018


Caught by UBSAN

Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
---
 drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
index d644a9bb9078..a9c386fd9493 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
@@ -98,7 +98,7 @@ int smu7_copy_bytes_to_smc(struct pp_hwmgr *hwmgr, uint32_t smc_start_address,
 
 	while (byte_count >= 4) {
 	/* Bytes are written into the SMC addres space with the MSB first. */
-		data = src[0] * 0x1000000 + src[1] * 0x10000 + src[2] * 0x100 + src[3];
+		data = src[0] * 0x1000000U + src[1] * 0x10000U + src[2] * 0x100U + src[3];
 
 		result = smu7_set_smc_sram_address(hwmgr, addr, limit);
 
-- 
2.17.1



More information about the amd-gfx mailing list