[bug report] drm/amd/display: Fix indentation in dcn10 resource constructor

Dan Carpenter dan.carpenter at oracle.com
Wed Jun 27 13:14:23 UTC 2018


Hello Hersen Wu,

The patch cb1d7eacb58f: "drm/amd/display: Fix indentation in dcn10
resource constructor" from May 8, 2018, leads to the following static
checker warning:

	drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1008 construct()
	warn: inconsistent indenting

drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c
   996  static bool construct(
   997          uint8_t num_virtual_links,
   998          struct dc *dc,
   999          struct dcn10_resource_pool *pool)
  1000  {
  1001          int i;
  1002          int j;
  1003          struct dc_context *ctx = dc->ctx;
  1004          uint32_t pipe_fuses = read_pipe_fuses(ctx);
  1005  
  1006          ctx->dc_bios->regs = &bios_regs;
  1007  
  1008                  pool->base.res_cap = &res_cap;
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This line was indented correctly in the original code when it was merged
last November...  It's a mystery.  Merge error perhaps?

https://www.mail-archive.com/amd-gfx@lists.freedesktop.org/msg21750.html

  1009  
  1010          pool->base.funcs = &dcn10_res_pool_funcs;
  1011  
  1012          /*
  1013           * TODO fill in from actual raven resource when we create
  1014           * more than virtual encoder
  1015           */

regards,
dan carpenter


More information about the amd-gfx mailing list