[PATCH] drm/amdgpu: Remove some unused elements from amdgpu_connector struct

Alex Deucher alexdeucher at gmail.com
Fri Mar 9 04:31:51 UTC 2018


On Thu, Mar 8, 2018 at 8:45 PM, Harry Wentland <harry.wentland at amd.com> wrote:
> They were used by amdgpu_dm at some point but since it has its own
> amdgpu_dm_connector now these aren't needed anymore.
>
> Signed-off-by: Harry Wentland <harry.wentland at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 29 -----------------------------
>  1 file changed, 29 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> index b9841e37032c..da695c5952c4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> @@ -554,14 +554,6 @@ struct amdgpu_connector {
>         /* we need to mind the EDID between detect
>            and get modes due to analog/digital/tvencoder */
>         struct edid *edid;
> -       /* number of modes generated from EDID at 'dc_sink' */
> -       int num_modes;
> -       /* The 'old' sink - before an HPD.
> -        * The 'current' sink is in dc_link->sink. */
> -       struct dc_sink *dc_sink;
> -       struct dc_link *dc_link;
> -       struct dc_sink *dc_em_sink;
> -       const struct dc_stream *stream;
>         void *con_priv;
>         bool dac_load_detect;
>         bool detected_by_load; /* if the connection status was determined by load */
> @@ -572,27 +564,6 @@ struct amdgpu_connector {
>         enum amdgpu_connector_audio audio;
>         enum amdgpu_connector_dither dither;
>         unsigned pixelclock_for_modeset;
> -
> -       struct drm_dp_mst_topology_mgr mst_mgr;
> -       struct amdgpu_dm_dp_aux dm_dp_aux;
> -       struct drm_dp_mst_port *port;
> -       struct amdgpu_connector *mst_port;
> -       struct amdgpu_encoder *mst_encoder;
> -       struct semaphore mst_sem;
> -
> -       /* TODO see if we can merge with ddc_bus or make a dm_connector */
> -       struct amdgpu_i2c_adapter *i2c;
> -
> -       /* Monitor range limits */
> -       int min_vfreq ;
> -       int max_vfreq ;
> -       int pixel_clock_mhz;
> -
> -       /*freesync caps*/
> -       struct mod_freesync_caps caps;
> -
> -       struct mutex hpd_lock;
> -
>  };
>
>  /* TODO: start to use this struct and remove same field from base one */
> --
> 2.14.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list