[PATCH] drm/amdgpu: save/restore backlight level in legacy dce code

Harry Wentland harry.wentland at amd.com
Fri Mar 9 14:13:45 UTC 2018


On 2018-03-09 03:44 AM, Michel Dänzer wrote:
> On 2018-03-08 09:21 PM, Alex Deucher wrote:
>> Save/restore the backlight level scratch register in S3/S4 so the
>> backlight level comes back at the previously requested level.
>>
>> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=199047
>> Fixes: 4ec6ecf48c64d (drm/amdgpu: drop scratch regs save and restore from S3/S4 handling)
>> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> 
> Acked-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> Might be nice to get Harry or someone else from the display team to take
> a look as well.
> 

Non-DC code path for backlight is completely different for backlight than DC's but from what I can see in atombios_encoder and given that this fixes a fallout due to no longer saving the scratch regs this patch looks good to me.

Reviewed-by: Harry Wentland <harry.wentland at amd.com>

Harry


More information about the amd-gfx mailing list