[PATCH 1/2] drm/amdgpu: Improve documentation of bo_ptr in amdgpu_bo_create_kernel

[Christian König]

Am 14.03.2018 um 19:07 schrieb Andrey Grodzovsky:
> and amdgpu_bo_create_reserved.
>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 48e0115..11673c3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -171,7 +171,7 @@ void amdgpu_ttm_placement_from_domain(struct amdgpu_bo *abo, u32 domain)
>    * @size: size for the new BO
>    * @align: alignment for the new BO
>    * @domain: where to place it
> - * @bo_ptr: resulting BO
> + * @bo_ptr: resulting BO (new BO is created if bo_ptr is NULL)

Maybe add "only" here, e.g. new BO is only created if bo_ptr points to NULL.

And add something like "used to initialize BOs in structures".

Either way the patch is Reviewed-by: Christian König 
<christian.koenig at amd.com>.

Christian.

>    * @gpu_addr: GPU addr of the pinned BO
>    * @cpu_addr: optional CPU address mapping
>    *
> @@ -240,7 +240,7 @@ int amdgpu_bo_create_reserved(struct amdgpu_device *adev,
>    * @size: size for the new BO
>    * @align: alignment for the new BO
>    * @domain: where to place it
> - * @bo_ptr: resulting BO
> + * @bo_ptr: resulting BO (new BO is created if bo_ptr is NULL)
>    * @gpu_addr: GPU addr of the pinned BO
>    * @cpu_addr: optional CPU address mapping
>    *