[PATCH] drm/amd/powerplay: Fix NULL pointer deref on driver unbind.

Deucher, Alexander Alexander.Deucher at amd.com
Mon Mar 19 21:16:20 UTC 2018


Reviewed-by: Alex Deucher <alexander.deucher at amd.com>


________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Andrey Grodzovsky <andrey.grodzovsky at amd.com>
Sent: Monday, March 19, 2018 4:55 PM
To: amd-gfx at lists.freedesktop.org
Cc: Grodzovsky, Andrey; Zhu, Rex
Subject: [PATCH] drm/amd/powerplay: Fix NULL pointer deref on driver unbind.

Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky at amd.com>
---
 drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index 3da3dcc..dbb0e69 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -286,6 +286,12 @@ static int pp_resume(void *handle)
         return hwmgr_hw_resume(hwmgr);
 }

+static int pp_set_clockgating_state(void *handle,
+                                         enum amd_clockgating_state state)
+{
+       return 0;
+}
+
 static const struct amd_ip_funcs pp_ip_funcs = {
         .name = "powerplay",
         .early_init = pp_early_init,
@@ -300,7 +306,7 @@ static const struct amd_ip_funcs pp_ip_funcs = {
         .is_idle = pp_is_idle,
         .wait_for_idle = pp_wait_for_idle,
         .soft_reset = pp_sw_reset,
-       .set_clockgating_state = NULL,
+       .set_clockgating_state = pp_set_clockgating_state,
         .set_powergating_state = pp_set_powergating_state,
 };

--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180319/fd2c4fca/attachment.html>


More information about the amd-gfx mailing list