[PATCH] drm/amd/powerplay: Enable ACG SS feature

[Huang Rui]

On Wed, Mar 28, 2018 at 03:51:16PM +0800, Kenneth Feng wrote:
> port the new atomfirmware.h change in order to
> support ACG SS feature and populate the ACG SS
> parameters into SMU
> 

We would better to say "update atomfirmware header". Because the guys who
are in community not from AMD will not know where you port it.

> Change-Id: I3297b93b166abc6e430d14ccdd362e353771ea36
> Signed-off-by: Kenneth Feng <kenneth.feng at amd.com>
> ---
>  drivers/gpu/drm/amd/include/atomfirmware.h         | 12 ++++++++----
>  drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.c | 10 +++++++---
>  drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.h | 22 +++++++++++++---------
>  .../amd/powerplay/hwmgr/vega12_processpptables.c   | 11 ++++++++---
>  .../drm/amd/powerplay/inc/vega12/smu9_driver_if.h  | 14 +++++++++-----
>  5 files changed, 45 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h b/drivers/gpu/drm/amd/include/atomfirmware.h
> index 3ae3da4..0f5ad54 100644
> --- a/drivers/gpu/drm/amd/include/atomfirmware.h
> +++ b/drivers/gpu/drm/amd/include/atomfirmware.h
> @@ -1264,9 +1264,9 @@ struct atom_smc_dpm_info_v4_1
>    uint8_t  ledpin2;
>    uint8_t  padding8_4;
>  
> -  uint8_t  gfxclkspreadenabled;
> -  uint8_t  gfxclkspreadpercent;
> -  uint16_t gfxclkspreadfreq;
> +	uint8_t  pllgfxclkspreadenabled;
> +	uint8_t  pllgfxclkspreadpercent;
> +	uint16_t pllgfxclkspreadfreq;
>  

<snip>

> -	param->gfxclkspreadenabled = info->gfxclkspreadenabled;
> -	param->gfxclkspreadpercent = info->gfxclkspreadpercent;
> -	param->gfxclkspreadfreq = info->gfxclkspreadfreq;
> +	param->pllgfxclkspreadenabled = info->pllgfxclkspreadenabled;
> +	param->pllgfxclkspreadpercent = info->pllgfxclkspreadpercent;
> +	param->pllgfxclkspreadfreq = info->pllgfxclkspreadfreq;
>  

<snip>

> -  uint8_t  gfxclkspreadenabled;
> -  uint8_t  gfxclkspreadpercent;
> -  uint16_t gfxclkspreadfreq;
> +	uint8_t  pllgfxclkspreadenabled;
> +	uint8_t  pllgfxclkspreadpercent;
> +	uint16_t pllgfxclkspreadfreq;

<snip>

> -	ppsmc_pptable->GfxclkSpreadEnabled = smc_dpm_table.gfxclkspreadenabled;
> -	ppsmc_pptable->GfxclkSpreadPercent = smc_dpm_table.gfxclkspreadpercent;
> -	ppsmc_pptable->GfxclkSpreadFreq = smc_dpm_table.gfxclkspreadfreq;
> +	ppsmc_pptable->PllGfxclkSpreadEnabled = smc_dpm_table.pllgfxclkspreadenabled;
> +	ppsmc_pptable->PllGfxclkSpreadPercent = smc_dpm_table.pllgfxclkspreadpercent;
> +	ppsmc_pptable->PllGfxclkSpreadFreq = smc_dpm_table.pllgfxclkspreadfreq;

<snip>

>  
> -  uint8_t      GfxclkSpreadEnabled;
> -  uint8_t      GfxclkSpreadPercent;
> -  uint16_t     GfxclkSpreadFreq;
> +	uint8_t      PllGfxclkSpreadEnabled;
> +	uint8_t      PllGfxclkSpreadPercent;
> +	uint16_t     PllGfxclkSpreadFreq;
>  

Above changes that in this patch actually just rename "gfxclkspread*" to
"pplgfxclkstread*", and not related directly with ACG. So I suggested that
you can make another patch as "drm/amd/powerplay: rename gfxclk to
pplgfxclk to align atom firmware interfaces". 

With that fixed, patches are
Reviewed-by: Huang Rui <ray.huang at amd.com>

Thanks,
Ray