[PATCH] drm/amd/pp: Clean register first to avoid read original value

Eric Huang jinhuieric.huang at amd.com
Fri Mar 30 14:36:21 UTC 2018


It is not necessary to do that. The register will reset to 0 after reading.

Eric


On 03/30/2018 03:33 AM, Rex Zhu wrote:
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
> ---
>   drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index aaa9f5b..38cf3a1 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -3368,6 +3368,19 @@ static int smu7_get_gpu_power(struct pp_hwmgr *hwmgr,
>   			"Failed to start pm status log!",
>   			return -1);
>   
> +	cgs_write_ind_register(hwmgr->device,
> +			CGS_IND_REG__SMC,
> +			ixSMU_PM_STATUS_40, 0);
> +	cgs_write_ind_register(hwmgr->device,
> +			CGS_IND_REG__SMC,
> +			ixSMU_PM_STATUS_49, 0);
> +	cgs_write_ind_register(hwmgr->device,
> +			CGS_IND_REG__SMC,
> +			ixSMU_PM_STATUS_94, 0);
> +	cgs_write_ind_register(hwmgr->device,
> +			CGS_IND_REG__SMC,
> +			ixSMU_PM_STATUS_95, 0);
> +
>   	/* Sampling period from 50ms to 4sec */
>   	msleep_interruptible(200);
>   



More information about the amd-gfx mailing list