[PATCH 2/2] drm/amdgpu/display: fix vega12/20 handling in dal_asic_id.h

[Harry Wentland]

On 2018-05-16 04:37 PM, Alex Deucher wrote:
> - Remove unused ASICREV_IS_VEGA12_p() macro
> - Fix ASICREV_IS_VEGA12_P() macro to properly check against vega20
> 
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Both patches are
Reviewed-by: Harry Wentland <harry.wentland at amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/include/dal_asic_id.h | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/include/dal_asic_id.h b/drivers/gpu/drm/amd/display/include/dal_asic_id.h
> index cac069dd2a0e..25029ed42d89 100644
> --- a/drivers/gpu/drm/amd/display/include/dal_asic_id.h
> +++ b/drivers/gpu/drm/amd/display/include/dal_asic_id.h
> @@ -115,19 +115,17 @@
>  /* DCE12 */
>  #define AI_UNKNOWN 0xFF
>  
> -#define AI_VEGA20_P_A0 40
> -#define ASICREV_IS_VEGA20_P(eChipRev) ((eChipRev >= AI_VEGA20_P_A0) && (eChipRev < AI_UNKNOWN))
> -
>  #define AI_GREENLAND_P_A0 1
>  #define AI_GREENLAND_P_A1 2
>  #define AI_UNKNOWN 0xFF
>  
>  #define AI_VEGA12_P_A0 20
> +#define AI_VEGA20_P_A0 40
>  #define ASICREV_IS_GREENLAND_M(eChipRev)  (eChipRev < AI_VEGA12_P_A0)
>  #define ASICREV_IS_GREENLAND_P(eChipRev)  (eChipRev < AI_VEGA12_P_A0)
>  
> -#define ASICREV_IS_VEGA12_P(eChipRev) ((eChipRev >= AI_VEGA12_P_A0) && (eChipRev < AI_UNKNOWN))
> -#define ASICREV_IS_VEGA12_p(eChipRev) ((eChipRev >= AI_VEGA12_P_A0) && (eChipRev < AI_UNKNOWN))
> +#define ASICREV_IS_VEGA12_P(eChipRev) ((eChipRev >= AI_VEGA12_P_A0) && (eChipRev < AI_VEGA20_P_A0))
> +#define ASICREV_IS_VEGA20_P(eChipRev) ((eChipRev >= AI_VEGA20_P_A0) && (eChipRev < AI_UNKNOWN))
>  
>  /* DCN1_0 */
>  #define INTERNAL_REV_RAVEN_A0             0x00    /* First spin of Raven */
>