[PATCH] drm/amd/pp: missing curly braces in smu7_enable_sclk_mclk_dpm()

Alex Deucher alexdeucher at gmail.com
Thu May 17 15:38:49 UTC 2018


On Thu, May 17, 2018 at 8:56 AM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> We added some more lines of code to this if statement but forgot to add
> curly braces.
>
> Fixes: 0c24e7ef233b ("drm/amd/powerplay: add specific changes for VEGAM in smu7_hwmgr.c")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Applied.  thanks!

Alex

>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index 8eb3f5176646..646c9e9bf681 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -1018,7 +1018,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>         struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
>
>         /* enable SCLK dpm */
> -       if (!data->sclk_dpm_key_disabled)
> +       if (!data->sclk_dpm_key_disabled) {
>                 if (hwmgr->chip_id == CHIP_VEGAM)
>                         smu7_disable_sclk_vce_handshake(hwmgr);
>
> @@ -1026,6 +1026,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>                 (0 == smum_send_msg_to_smc(hwmgr, PPSMC_MSG_DPM_Enable)),
>                 "Failed to enable SCLK DPM during DPM Start Function!",
>                 return -EINVAL);
> +       }
>
>         /* enable MCLK dpm */
>         if (0 == data->mclk_dpm_key_disabled) {
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list