[PATCH xf86-video-amdgpu 03/13] List disabled color properties on RandR outputs without a CRTC

Leo Li sunpeng.li at amd.com
Thu May 17 21:43:29 UTC 2018



On 2018-05-16 01:09 PM, Michel Dänzer wrote:
> On 2018-05-03 08:31 PM, sunpeng.li at amd.com wrote:
>> From: "Leo (Sunpeng) Li" <sunpeng.li at amd.com>
>>
>> The properties on an RandR output needs to stay consistent throughout
>> it's lifecycle. However, we cannot list color properties on an output if
>> there is no CRTC attached.
>>
>> Therefore, create a fake CRTC, and initialize "disabled" color
>> properites on outputs without a CRTC.
>>
>> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li at amd.com>
> 
> If this patch remains: I don't get the point of the fake CRTC. AFAICT
> rr_configure_and_change_cm_property could simply handle a NULL crtc more
> or less the same way it does the fake one?
> 
> 

It does look like it can. Modifying the conditionals from
`if (crtc->gamma_lut)` to `if (crtc && crtc->gamma_lut)` should do the
trick. Thanks for catching this.

Leo


More information about the amd-gfx mailing list