[PATCH] drm/amdgpu: consider user preference when pinning for SG display

[Michel Dänzer]

On 2018-05-18 09:12 PM, Alex Deucher wrote:
> On Fri, May 18, 2018 at 4:21 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> On 2018-05-17 06:55 PM, Alex Deucher wrote:
>>> If the pin domain is set to GTT | VRAM, look at the preferred domains
>>> for the bo and respect that if it's been set explicitly.
>>>
>>> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>
> [...]
>
>>> +             else if (adev->gmc.real_vram_size <= AMDGPU_SG_THRESHOLD)
>>>                       domain = AMDGPU_GEM_DOMAIN_GTT;
>>> +             else
>>> +                     domain = AMDGPU_GEM_DOMAIN_VRAM;
>>>       }
>>
>> Is everything in place to deal with any issues that might occur when
>> flipping between buffers in VRAM and GTT?
> 
> Ah, right, I forgot about that, we still need to do that.  In practice
> I don't think this will change anything compared things now at least
> the way mesa is currently configured.  I can hold off on this this
> patch for now until we handle that if you think it will be an issue.

Apart from relying on userspace behaviour, it could be an issue when a
DRI3 client using a different driver than glamor (e.g. Vulkan or
amdgpu-pro OpenGL) starts or stops page flipping (both cases involve a
flip between a server-allocated and a client-allocated buffer).


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer