[PATCH 02/17] drm/amdgpu: add vcn jpeg ring

[Leo Liu]

On 05/25/2018 05:08 AM, Christian König wrote:
> Am 24.05.2018 um 22:15 schrieb boyuan.zhang at amd.com:
>> From: Boyuan Zhang <boyuan.zhang at amd.com>
>>
>> Add jpeg to amdgpu_vcn
>>
>> Signed-off-by: Boyuan Zhang <boyuan.zhang at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
>> index 2fd7db8..648f662 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
>> @@ -55,9 +55,11 @@ struct amdgpu_vcn {
>>       const struct firmware    *fw;    /* VCN firmware */
>>       struct amdgpu_ring    ring_dec;
>>       struct amdgpu_ring    ring_enc[AMDGPU_VCN_MAX_ENC_RINGS];
>> +    struct amdgpu_ring    ring_jpeg;
>>       struct amdgpu_irq_src    irq;
>>       struct drm_sched_entity entity_dec;
>>       struct drm_sched_entity entity_enc;
>> +    struct drm_sched_entity entity_jpeg;
>
> Why do you need the entity here? I thought the JPEG ring is stateles?
Right. We don't even need them for dec and enc. I think there is a 
copy-over from legacy UVD/VCE stuff with handles limitation, for that we 
need scheduler involved to send a destroy message.

I will come up a patch to remove those entities for dec and enc.

Regards,
Leo


>
> Christian.
>
>>       unsigned        num_enc_rings;
>>   };
>