DC regression in 4.17 broke suspend to RAM

[Michel Dänzer]

On 2018-05-28 03:44 PM, Leo Li wrote:
> On 2018-05-28 05:15 AM, Michel Dänzer wrote:
>>
>> Hi Leo,
>>
>>
>> commit e277adc5a06c "drm/amd/display: Hookup color management functions"
>> broke suspend to RAM on my development system with a Tonga and a Turks
>> (using the radeon driver). It sometimes, but not always happens when
>> trying to suspend from the GNOME login screen in Wayland mode (I first
>> noticed the problem when that started happening automatically after a
>> timeout). I can reproduce it reliably by logging into a GNOME on Wayland
>> session and suspending from there.
>>
>> The BUG_ON added by this commit triggers during suspend, see below. This
>> prevents the suspend (and later system shutdown as well) from
>> completing.
>>
> 
> Thanks for the heads up. Can you give the patch on this ticket a try?
> https://bugs.freedesktop.org/show_bug.cgi?id=106194

The patch fixes the problem for me, and I don't get the REG_WAIT timeout
splat reported by Aaron in the bug report.


Since this regression affects mainline for the upcoming 4.17 release,
unless there's any particular risk associated with the fix, it should go
there ASAP. If you push it to amd-staging-drm-next this week, Alex might
be able to sneak it into the final 4.17 release, which is expected on
Sunday.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer