[PATCH] drm/amdgpu: revert "enable gfxoff in non-sriov and stutter mode by default"

[Alex Deucher]

On Wed, Oct 24, 2018 at 8:59 AM Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> This is still completely breaking my Raven system.
>
> This reverts commit cdf2f910fa969adca1b0e3ad2b487821233dc038.
>

With that addition of:
Revert until we sort out the sbios and firmware combinations that work
correctly.

bug: https://bugs.freedesktop.org/show_bug.cgi?id=108606
Cc: stable at vger.kernel.org # v4.19

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 --
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c    | 4 ++--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index d11489e8b388..926eeb09d4c8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1493,8 +1493,6 @@ static int amdgpu_device_ip_early_init(struct amdgpu_device *adev)
>         }
>
>         adev->powerplay.pp_feature = amdgpu_pp_feature_mask;
> -       if (amdgpu_sriov_vf(adev))
> -               adev->powerplay.pp_feature &= ~PP_GFXOFF_MASK;
>
>         for (i = 0; i < adev->num_ip_blocks; i++) {
>                 if ((amdgpu_ip_block_mask & (1 << i)) == 0) {
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 27528eeb444c..3b7d511031c6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -114,8 +114,8 @@ uint amdgpu_pg_mask = 0xffffffff;
>  uint amdgpu_sdma_phase_quantum = 32;
>  char *amdgpu_disable_cu = NULL;
>  char *amdgpu_virtual_display = NULL;
> -/* OverDrive(bit 14) disabled by default*/
> -uint amdgpu_pp_feature_mask = 0xffffbfff;
> +/* OverDrive(bit 14),gfxoff(bit 15),stutter mode(bit 17) disabled by default*/
> +uint amdgpu_pp_feature_mask = 0xfffd3fff;
>  int amdgpu_ngg = 0;
>  int amdgpu_prim_buf_per_se = 0;
>  int amdgpu_pos_buf_per_se = 0;
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx