[PATCH 0/3] RLC kernel code update to improve resuabillity

Christian K├Ânig ckoenig.leichtzumerken at gmail.com
Mon Nov 5 13:16:47 UTC 2018


Hi Likun,

I'm not deep enough into what and how the RLC does it's job to 
completely judge but in general that looks like a really nice cleanup.

Just two notes:
1. Don't add function first to amdgpu_gfx.[ch] and in the next patch 
move them over to amdgpu_rlc.[ch]. Just add them directly to the later 
and if you find something in amdgpu_gfx.c which should be in 
amdgpu_rlc.c move it over in an additional patch.

2. When you add common function which apply to all hw generations then 
please add kernel documentation for them.

Regards,
Christian.

Am 05.11.18 um 13:47 schrieb likun Gao:
> From: Likun Gao <Likun.Gao at amd.com>
>
> Hi,
>
> Those series of patch modified the code of RLC to improve the resuabillity of
> RLC's code. The process was separate into three part:
> Part1[PATCH 1/3]: Unify RLC's function into the struct amdgpu_rlc_funcs and change the
> method of calling RLC.
> Part2[PATCH 2/3]: Abstract RLC's function from the function struct for each
> version of GFX to improve the resuability of RLC's function code.
> Part3[PATCH 3/3]: Separate RLC's code from the file of amdgpu_gfx.
>
> Please help to review.
>
> Regards,
> Likun
>
> Likun Gao (3):
>    drm/amdgpu: unify rlc function into structure
>    drm/amdgpu: abstract the function of enter/exit safe mode for RLC.
>    drm/amdgpu: separate amdgpu_rlc into a single file.
>
>   drivers/gpu/drm/amd/amdgpu/Makefile                |   1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c            |   1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h            |  54 +----
>   drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c            | 228 ++++++++++++++++++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h            |  98 +++++++++
>   drivers/gpu/drm/amd/amdgpu/ci_dpm.c                |   6 +-
>   drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c              |  56 ++---
>   drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c              | 176 ++++------------
>   drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c              | 230 +++++++--------------
>   drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c              | 215 +++++--------------
>   drivers/gpu/drm/amd/amdgpu/kv_dpm.c                |   6 +-
>   .../gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c   |  12 +-
>   .../gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c |  36 ++--
>   13 files changed, 545 insertions(+), 574 deletions(-)
>   create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
>   create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h
>



More information about the amd-gfx mailing list