[PATCH] drm/amdgpu: disable page queue on Vega10 SR-IOV VF

Christian König ckoenig.leichtzumerken at gmail.com
Wed Nov 7 07:59:23 UTC 2018


Am 07.11.18 um 06:15 schrieb Trigger Huang:
> Currently, SDMA page queue is not used under SR-IOV VF, and this queue will
> cause ring test failure in amdgpu module reload case. So just disable it.
>
> Signed-off-by: Trigger Huang <Trigger.Huang at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index e39a09eb0f..4edc848 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -1451,7 +1451,9 @@ static int sdma_v4_0_early_init(void *handle)
>   		adev->sdma.has_page_queue = false;
>   	} else {
>   		adev->sdma.num_instances = 2;
> -		if (adev->asic_type != CHIP_VEGA20 &&
> +		if ((adev->asic_type == CHIP_VEGA10) && amdgpu_sriov_vf((adev)))
> +			adev->sdma.has_page_queue = false;
> +		else if (adev->asic_type != CHIP_VEGA20 &&

Please add a /* TODO: Page queue breaks driver reload under SRIOV */ 
comment.

With that done the patch is Reviewed-by: Christian König 
<christian.koenig at amd.com>.

Regards,
Christian.

>   				adev->asic_type != CHIP_VEGA12)
>   			adev->sdma.has_page_queue = true;
>   	}



More information about the amd-gfx mailing list