[PATCH] drm/amdgpu: Remove dead static variable

Koenig, Christian Christian.Koenig at amd.com
Tue Nov 20 11:47:04 UTC 2018


Am 20.11.18 um 11:48 schrieb Emil Velikov:
> On Mon, 19 Nov 2018 at 11:19, Christian König
> <ckoenig.leichtzumerken at gmail.com> wrote:
>> Am 19.11.18 um 12:07 schrieb Rex Zhu:
>>> The static struct drm_driver *driver was
>>> not used because drm_pci_init was deprecated
>>>
>>> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
>> Reviewed-by: Christian König <christian.koenig at amd.com>
>>
>> Can you of hand see what "pdriver" is used for? That looks suspicious
>> like something deprecated as well.
>>
> Seeming copy/paste from the radeon driver. The latter used to support
> UMS and KMS at some point in the past.

Yeah, thought so. Rex cam up with a V2 where both variables are removed.

Thanks,
Christian.

>
> HTH
> -Emil



More information about the amd-gfx mailing list