[PATCH] drm/amd/display: fix uninitialized symbol 'id' in bios_parser_get_src_obj
Yang Xiao
YangX92 at hotmail.com
Wed Nov 28 02:02:33 UTC 2018
From: Young Xiao <YangX92 at hotmail.com>
See commit a8f976473196 ("drm/amd/display: Bunch of smatch error and
warning fixes in DC") for detail.
Signed-off-by: Young Xiao <YangX92 at hotmail.com>
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
index 0e1dc1b..6420546 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
@@ -188,7 +188,7 @@ static enum bp_result bios_parser_get_src_obj(struct dc_bios *dcb,
struct graphics_object_id *src_object_id)
{
uint32_t number;
- uint16_t *id;
+ uint16_t *id = NULL;
ATOM_OBJECT *object;
struct bios_parser *bp = BP_FROM_DCB(dcb);
@@ -204,7 +204,7 @@ static enum bp_result bios_parser_get_src_obj(struct dc_bios *dcb,
number = get_src_obj_list(bp, object, &id);
- if (number <= index)
+ if (number <= index || !id)
return BP_RESULT_BADINPUT;
*src_object_id = object_id_from_bios_object_id(id[index]);
--
2.7.4
More information about the amd-gfx
mailing list